Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/dag: fix tests from #4169 #4175

Merged
merged 1 commit into from
Nov 11, 2021
Merged

Conversation

skriss
Copy link
Member

@skriss skriss commented Nov 11, 2021

Fixes some logical merge conflicts in
the tests from #4169.

Signed-off-by: Steve Kriss krisss@vmware.com

Fixes some logical merge conflicts in
the tests from projectcontour#4169.

Signed-off-by: Steve Kriss <krisss@vmware.com>
@skriss skriss requested a review from a team as a code owner November 11, 2021 15:43
@skriss skriss requested review from sunjayBhatia and youngnick and removed request for a team November 11, 2021 15:43
@skriss skriss added the release-note/none-required Marks a PR as not requiring a release note. Should only be used for very small changes. label Nov 11, 2021
@skriss skriss requested a review from stevesloka November 11, 2021 15:46
@codecov
Copy link

codecov bot commented Nov 11, 2021

Codecov Report

Merging #4175 (61555be) into main (c0bab09) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4175      +/-   ##
==========================================
+ Coverage   75.65%   75.70%   +0.05%     
==========================================
  Files         111      111              
  Lines        9613     9633      +20     
==========================================
+ Hits         7273     7293      +20     
  Misses       2186     2186              
  Partials      154      154              
Impacted Files Coverage Δ
internal/dag/httpproxy_processor.go 92.73% <100.00%> (+0.01%) ⬆️
internal/featuretests/v3/envoy.go 100.00% <100.00%> (ø)

@skriss
Copy link
Member Author

skriss commented Nov 11, 2021

Merging this now to fix this part, upgrade test failure to be dealt with separately.

@skriss skriss merged commit b897984 into projectcontour:main Nov 11, 2021
@skriss skriss deleted the upd-4169 branch November 11, 2021 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/none-required Marks a PR as not requiring a release note. Should only be used for very small changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants